hhmx.de

· Föderation EN Sa 24.05.2025 05:35:58

@jawnsy @Lucomo The reviewer still has to expend effort to properly review the change regardless of how responsible the original developer is for code quality. It takes time to look at the 5k line PR to figure out that it could've and should've been a much simpler change.

Föderation EN Sa 24.05.2025 06:11:07

@adamsnotes @Lucomo What I'm saying is that, if a reviewer is confronted with a 5k line change, they should feel empowered to reject it until the author can convince them that it's safe and that it's the minimal change necessary.

Big projects like Kubernetes do have big PRs sometimes, but I thinkthey are from people who have a reputation in the project and thus a high degree of trust. I imagine that a lot are simply rejected without much review if they come from new contributors

Föderation EN Sa 24.05.2025 07:05:36

@jawnsy @Lucomo I suppose this plays out differently in Open Source vs the Corporate world.

OS can easily bounce a PR from a contributor of it's not up to snuff, but within a corporate environment the politics can be a bit more problematic, so you do need to justify your review.