|
Föderation EN Fr 23.05.2025 09:17:16 AI is a horrible tool in software development. A team leader explains the problems in this post on Reddit: "AI Slop PR's are burning me and my team out hard" Medien: 1 |
|
Föderation EN Sa 24.05.2025 00:09:11 @Lucomo If senior devs did this, I'd be very irritated and I'd have a serious conversation with them about it. |
|
Föderation EN Sa 24.05.2025 00:38:13 @ryanjyoder @Lucomo this very much sounds like a "you're holding it wrong" argument. The fact that these tools do allow junior devs to submit wild & ungrounded PRs is itself a major, major problem. |
|
Föderation EN Sa 24.05.2025 00:40:47 @jaredwhite @Lucomo |
|
Föderation EN Sa 24.05.2025 02:48:40 @ryanjyoder @jaredwhite @Lucomo PRs copied from StackOverflow don't change 5k+ lines of code |
|
Föderation EN Sa 24.05.2025 09:01:55 @Ash_Crow @ryanjyoder @jaredwhite @Lucomo if a junior dev would do this, they would have a very serious talk. This is not just copying code you don’t understand, it’s deliberately wracking the system Medien: 1 |
|
Föderation EN Sa 24.05.2025 00:24:18 @Lucomo depending on the context, people responsible for reviewing code like this have to be allowed to decline the review if the programmers want to take responsibility for it. I say let it burn so people see what happens. It's so bad for code reviewers' mental health. |
|
Föderation EN Sa 24.05.2025 02:46:39 @990000 @Lucomo if you are not allowed to say no to PRs why are you spending time reviewing them? |
|
Föderation EN Sa 24.05.2025 03:38:39 @kevingranade @990000 @Lucomo The problem is that figuring out that e.g. auth was skipped takes way more than 10s. |
|
Föderation EN Sa 24.05.2025 04:39:17 @Anibyl @990000 @Lucomo yes the almost right ones are the worst, but it kind of sounds like they were doing subtle stuff like that and also absurd out of control nonsense at the same time and they're being told to review and merge it anyway. My point is the ai is ludicrously bad, but the real failure here is them apparently not being allowed to say no to egregiously bad PRs. |
|
Föderation EN Sa 24.05.2025 08:47:38 @kevingranade @Anibyl @990000 @Lucomo This also shows how broken the current way people treat PRs. I see this a lot in small companies and corporate alike. If you have a PR as a single unit of work, and commits are meaningful changes, then 5k LOC PRs shouldn’t even be possible—unless you’re switching something in the code formatter or renaming a core thing. But those PRs should be exceptional and so similar that other changes are rejected instantly. |
|
Föderation EN Sa 24.05.2025 02:43:34 @Lucomo Regardless of tools (IDEs, StackOverflow, coding tools), I think authors of PRs are responsible for PR contents. And the burden of proof that a change is safe and desirable is on the author, not the reviewer. That's my current opinion, anyways :) |
|
Föderation EN Sa 24.05.2025 05:35:58 |
|
Föderation EN Sa 24.05.2025 06:11:07 @adamsnotes @Lucomo What I'm saying is that, if a reviewer is confronted with a 5k line change, they should feel empowered to reject it until the author can convince them that it's safe and that it's the minimal change necessary. Big projects like Kubernetes do have big PRs sometimes, but I thinkthey are from people who have a reputation in the project and thus a high degree of trust. I imagine that a lot are simply rejected without much review if they come from new contributors |
|
Föderation EN Sa 24.05.2025 07:05:36 |
|
Föderation EN Sa 24.05.2025 05:09:04 @Lucomo the whole world sucks now. :( |
|
Föderation EN Sa 24.05.2025 06:54:42 @Lucomo "I used AI to do it" really needs to sound more like "I asked my younger cousin to do it" |
|
Föderation EN Sa 24.05.2025 07:45:41 People in the comments suggesting, completely seriously, that the solution is to use an AI reviewer to review the PR before a human looks at it. JFC. |
|
Föderation · Sa 24.05.2025 08:08:21 @Lucomo lets be honest, if they can't be bothered to review the code before committing these same people would have been copy and pasting directly from stack overflow |
|
Föderation EN Sa 24.05.2025 09:22:34 @Lucomo I first read PR as Public Relations... Is it Product Review? |
|
Föderation EN Sa 24.05.2025 09:33:03 @temptoetiam @Lucomo Pull Request - without getting into the details of how Git works, it's when a contributor submits a proposed change in a software's code for the team maintaining it to look at. |
|
Föderation EN Sa 24.05.2025 09:50:20 @HauntedOwlbear @Lucomo thank you! |
|
Föderation EN Sa 24.05.2025 10:01:02 @HauntedOwlbear @temptoetiam @Lucomo Thsnks, was looking for this |
|
Föderation EN Sa 24.05.2025 09:35:22 @temptoetiam Pull request. That's GitHub lingo. GitLab, for instance, has merge requests. |
